Attention is currently required from: fixeria.

View Change

4 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #1, Line 15: __name__

    See my comment in `pySim-shell.py`.

    Done

  • Patch Set #1, Line 38: log = PySimLogger.get(__name__)

    This becomes an equivalent of the logger above, and thus can be removed?

    I remember having problems here. This code location was not able to access the globel log object. Maybe I should pass it with the constructor then?

• File pySim-shell.py:

  • Patch Set #1, Line 77: __name__

    Since this is the top level of the hierarchy, it's actually desirable to set the module name manuall […]

    Done

• File pySim/card_key_provider.py:

  • Patch Set #1, Line 41: PySimLogger.get

    You no longer need to call `PySimLogger.get` here nor in other modules of the `pySim` namespace. […]

    I gave this a try, but as it seems it is not the same.

    With the log object from PySimLogger.get I get:
    WARNING: HELLO (in yellow)

    With the log object from logging.getLogger I get
    HELLO (without color)

To view, visit change 41890. To unsubscribe, or for help writing mail filters, visit settings.