Attention is currently required from: csaba.sipos.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmo-bsc/bts_nokia_site.c:

  • Patch Set #1, Line 551: if

    I did not change anything, this is how it "comes". This is a typo in the "source". […]

    As far as I read the diff, the original code has "Abis If" for 0xFA and you replace it with "Abis if".

    It's not a critical issue, but I suggest we don't change existing names in a commit that states it only adds new definitions.

    So if you don't mind, follow the capitalization of the original code consistently in your new types. thanks.

    This is all not a blocker, I just stumbled across it.

To view, visit change 39252. To unsubscribe, or for help writing mail filters, visit settings.