Attention is currently required from: Hoernchen, laforge.

Patch set 1:Code-Review +1

View Change

3 comments:

• File firmware/libcommon/source/mode_cardemu.c:

  • Patch Set #1, Line 390: usart->US_FIDI = fidi & US_FIDI_FI_DI_RATIO_Msk;

    I would rather use US_FIDI_FI_DI_RATIO(fidi) here. It is correct, but only works
    because the bit position of US_FIDI_FI_DI_RATIO is 0.

• File firmware/libcommon/source/simtrace_iso7816.c:

  • Patch Set #1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) {

    It is correct, but because this is a define from ./libchip_sam3s/include/SAM3S.h I would have used a protocol define with 0x7fffu.

  • Patch Set #1, Line 137: usart->base->US_FIDI = (ratio & US_FIDI_FI_DI_RATIO_Msk);

    see previous usage of US_FIDI_FI_DI_RATIO(fidi)

To view, visit change 43125. To unsubscribe, or for help writing mail filters, visit settings.