Attention is currently required from: jolly.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/common/rsl.c:

  • Patch Set #1, Line 3839: if (msgb_l2len(msg) == sizeof(*rllh) && (rllh->link_id & 0xc7) == 0x00) {

    Using our union abis_rsl_link_id and then comparing sapin and cbits individually is probably the more higher-level / cleaner approach than doing low-level bit-masking which no developer understands off their head without reading the relevant spec section.

    It's not critical, I just think we should always try to aim making code as readable as possible. Open Source is not written to just execute, but to be read by other developers.

To view, visit change 35082. To unsubscribe, or for help writing mail filters, visit settings.