Attention is currently required from: arehbein, daniel, dexter, pespin.

Patch set 2:Code-Review -2

View Change

2 comments:

• File include/osmocom/netif/ipa.h:

  • Patch Set #2, Line 26: #warning "OSMO_IPA_MSGB_CB breaks the strict aliasing rule. Don't use unless -fno-strict-aliasing flag is enabled!"

    where are you seeing this problem? TBH I don't envision much of a problem here since we are accessin […]

    See the referenced https://osmocom.org/issues/6164.
    Aren't you seeing these warnings on Arch?

• File include/osmocom/netif/ipa.h:

  • Patch Set #1, Line 21: osmo_ipa_msgb_cb

    Ah, alright. […]

    Is this warning going to show up when compiling any files including this header and not necessarily using `OSMO_IPA_MSGB_CB`? If so, I am against this `#warning` pragma.

To view, visit change 34445. To unsubscribe, or for help writing mail filters, visit settings.