laforge submitted this change.

View Change

Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified
msc: Fix TC_stat_bsc_sctp_disconnected expectancies

The test was passing when run alone, but was failing when run after
other tests using other BSCs/RNCs, since osmo-msc learned about them and
hence ran_peers.total was >1.

Change-Id: I22da7ae5c282a30e933f2f29b671ece8b6147ce9
---
M msc/MSC_Tests.ttcn
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 013ecfd..c85a458 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -7671,12 +7671,14 @@
var BSC_ConnHdlrPars pars;
var charstring msc_stats_prefix := f_msc_stats_prefix();

+ /* ran_peers.total: Despite we only use 1 RAN_CONN in this test, previous tests may have
+ * used more of them (up to configured NUM_BSC), and hence IUT may remember about them: */
var StatsDExpects expect_connected := {
- {name := msc_stats_prefix & "ran_peers.total", mtype := "g", min := 1, max := 1},
+ {name := msc_stats_prefix & "ran_peers.total", mtype := "g", min := 1, max := NUM_BSC},
{name := msc_stats_prefix & "ran_peers.active", mtype := "g", min := 1, max := 1}
};
var StatsDExpects expect_disconnected := {
- {name := msc_stats_prefix & "ran_peers.total", mtype := "g", min := 1, max := 1},
+ {name := msc_stats_prefix & "ran_peers.total", mtype := "g", min := 1, max := NUM_BSC},
{name := msc_stats_prefix & "ran_peers.active", mtype := "g", min := 0, max := 0}
};


To view, visit change 41641. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I22da7ae5c282a30e933f2f29b671ece8b6147ce9
Gerrit-Change-Number: 41641
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>