Attention is currently required from: fixeria.
1 comment:
Patchset:
Without even looking at the changes and only reading the commit description, I believe this approach is incorrect.
Since you cannot anyway guarantee that all remaining data will be written synchronously, and in order to guarantee it you'd need to potentially block, this is not fesabile/appropriate.
You need to instead account for the bytes submitted to the iofd, and then calculate how many bytes are enqueued and not yet written through tracking written bytes in the write_cb. See how it's done in osmo-pcap.git ./src/osmo_pcap_wr_file.c
local_iofd_write_cb()
To view, visit change 43102. To unsubscribe, or for help writing mail filters, visit settings.