Hoernchen submitted this change.

View Change

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved
configure.ac: fix libtool issue with clang and sanitizer

As pointed out at https://github.com/libexpat/libexpat/issues/312
libtool does not play nice with clang sanitizer builds at all. For those
builds LD shoud be set to clang too (and LDFLAGS needs the sanitizer
flags as well), because the clang compiler driver knows how linking to
the sanitizer libs works, but then at a later stage libtool fails to
actually produce the shared libraries and the build fails. This is fixed
by this patch.

Addtionally LD_LIBRARY_PATH has no effect on conftest runs during
configure time, so the rpath needs to be set to the asan library path to
ensure the configure run does not fail due to a missing asan library,
i.e.:

SANS='-fsanitize=memory -fsanitize-recover=all -shared-libsan' export
CC=clang-10 ASANPATH=$(dirname `$CC
-print-file-name=libclang_rt.asan-x86_64.so`) export
LDFLAGS="-Wl,-rpath,$ASANPATH $SANS $LDFLAGS"

Change-Id: Ie38fa9985187c76b4e456d8b0a83006ef341b97e
---
M configure.ac
1 file changed, 5 insertions(+), 0 deletions(-)

diff --git a/configure.ac b/configure.ac
index 8c93c3f..6ba1d37 100644
--- a/configure.ac
+++ b/configure.ac
@@ -20,6 +20,11 @@

AC_CONFIG_MACRO_DIR([m4])

+dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang
+AS_CASE(["$LD"],[*clang*],
+ [AS_CASE(["${host_os}"],
+ [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])])
+
PKG_CHECK_MODULES(LIBTALLOC, talloc)

AC_ARG_ENABLE(sanitize,

To view, visit change 28174. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Change-Id: Ie38fa9985187c76b4e456d8b0a83006ef341b97e
Gerrit-Change-Number: 28174
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged