Attention is currently required from: falconia.

Patch set 4:Code-Review +2

View Change

4 comments:

• File include/osmo-bts/rtp_abstract.h:

  • Patch Set #3, Line 50: struct sockaddr_in local_addr;

    Please see my comment in the main IPv6 thread.

    Done

• File src/common/rtp_abstract.c:

  • Patch Set #3, Line 54: #ifdef HAVE_ORTP

    How do you propose doing so? Each function needs to check if the `rtp_abst_socket` it operates on wa […]

    Indeed when I was reviewing and writing the comment I thought you planned to enable one or the other at build time. It's fine then.

  • Patch Set #3, Line 97: rc = inet_aton(ipstr, &rs->local_addr.sin_addr);

    Please see my comment in the main IPv6 thread.

    Done

  • Patch Set #3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true);

    I added an extra comment in the code explaining this aspect.

    Done

To view, visit change 42165. To unsubscribe, or for help writing mail filters, visit settings.