Attention is currently required from: dexter, neels, pespin.

View Change

3 comments:

• File TODO-RELEASE:

  • Patch Set #3, Line 42: libosmocore bump_dep; workaround Bump libosmocore version dependency after I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5

    I'd usually simply write: […]

    I might simply remove the line and keep the local copy function, if we don't want to change msgb_copy semantics itself.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #3, Line 75: static inline struct msgb *mgw_msgb_copy_c(void *ctx, struct msgb *msg, const char *name)

    AS I mentioned in that patch, it may be worth having this API as a separate function in libosmocore.

    yes; even in that case, I'd introduce a local version here until those changes in libosmocore materialize.

  • Patch Set #3, Line 1375: if (conn_dst == conn)

    I think if you do this, then you can drop the entire block of code spanning lines 1360-1365: […]

    I think it would have to be the other way around:
    ```
    switch (conn_dst->mode) {
    case MGCP_CONN_SEND_ONLY:
    case MGCP_CONN_RECV_SEND:
            if (conn_dst == conn)
                continue;
            /* fall-through */
    case MGCP_CONN_CONFECHO:
            /* we have multiple recipients and must make copies for each recipient */
            msg2 = mgw_msgb_copy_c(conn_dst, msg, "RTP Tx copy");
            if (OSMO_LIKELY(msg2))
                    rc = mgcp_conn_rtp_dispatch_rtp(&conn_dst->u.rtp, msg2);

    ```

    In any case, that's a separate optimization and not related to changing msgb ownership.

To view, visit change 36361. To unsubscribe, or for help writing mail filters, visit settings.