Attention is currently required from: pespin, msuraev.

Patch set 3:Code-Review +2

View Change

1 comment:

• File src/osmux_input.c:

  • Patch Set #3, Line 156: ((state->circuit->last_transmitted_rtp_seq + 1) & 0xffff) != rtp_seqnum;

    sequence numbers are uint16_t in RTP. […]

    I guess max was indirectly saying "use UINT16_MAX" (probably just because it ends in his name). More seriously, I don't think we need to worry about 0xffff being considered a magic number. To me it's more obvious than UINT16_MAX.

To view, visit change 30196. To unsubscribe, or for help writing mail filters, visit settings.