Attention is currently required from: neels, pespin, dexter.

Patch set 19:Code-Review -1

View Change

3 comments:

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #19, Line 279: uint8_t pgroup;

    isn't pgroup going 0-999? that doesn't fit in a 8bit one (256)

    This is wrong. You cannot calculate a paging group in the PCU because you need to know more than just an IMSI to calculate it. And AFAIR, yes, it can be bigger than 255.

• File src/pcu_l1_if.cpp:

  • Patch Set #19, Line 298: pgroup

    I think this is where the confusion comes from. It's not a *paging group*, it's just three last digits of the IMSI. The argument needs to be renamed [in a separate patch]. See the related discussion: https://gerrit.osmocom.org/c/osmo-bts/+/31600/comments/edd450d1_1ff57336.

  • Patch Set #19, Line 771: } else {

    you cannot reach here according to if block in line 752.

    He's adding `info_ind->version != 0x0a` there, so it can be reached.

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.