laforge submitted this change.

View Change

Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved
eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly

When the testcase responds to the eIM with the error message, the error
code comes from a constant in the template. This means the testcase is
harder to understand and may break if the template changes. Let's set
the error code explcitly to avoid conflicts in the future.

Related: SYS#8100
Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40
---
M eim/eIM_Tests.ttcn
M library/euicc/SGP32Definitions_Templates.ttcn
2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn
index ca490db..b263eb8 100644
--- a/eim/eIM_Tests.ttcn
+++ b/eim/eIM_Tests.ttcn
@@ -929,8 +929,9 @@
eimTransactionId := valueof(esipa_res.getEimPackageResponse.ipaEuiccDataRequest.eimTransactionId);

/* Provide a plausible ipaEuiccDataResponse to the eIM */
- f_esipa_transceive(valueof(ts_provideEimPackageResult(eID, ts_eimPackageResult_euiccDataResp_err(eimTransactionId))),
- tr_provideEimPackageResultResponse_empty);
+ f_esipa_transceive(valueof(ts_provideEimPackageResult(eID,
+ ts_eimPackageResult_euiccDataResp_err(eimTransactionId, ipaEuiccDataErrorCode := 127))),
+ tr_provideEimPackageResultResponse_empty);

f_rest_lookup_resource(resource_id, "edr", tr_JSON_REST_success(outcome := expected_outcome) );
f_rest_delete_resource(resource_id, "edr");
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn
index a0f576d..ab27369 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -1562,11 +1562,12 @@
}
}
template (value) EimPackageResult
-ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring eimTransactionId := omit) := {
+ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring eimTransactionId := omit,
+ template (value) integer ipaEuiccDataErrorCode := 127) := {
ipaEuiccDataResponse := {
ipaEuiccDataResponseError := {
eimTransactionId := eimTransactionId,
- ipaEuiccDataErrorCode := 127
+ ipaEuiccDataErrorCode := ipaEuiccDataErrorCode
}
}
}

To view, visit change 43183. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40
Gerrit-Change-Number: 43183
Gerrit-PatchSet: 13
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>