Attention is currently required from: neels, laforge.

View Change

1 comment:

• File include/osmocom/hnbgw/context_map.h:

  • Patch Set #3, Line 70: MAP_SCCP_EV_CN_LINK_LOST,

    I've just explained to you in detail why "RX [RANAP] RESET" is not a good name.

    The main problem here is that "LINK_LOST" is too generic and difficult to understand from reader point of view. Is it RANAP RESET? is it SCTP association being ABORTED?
    If this event is used for both cases, then you can keep the "LINK_LOST" but update the comment to mention is used for all kind of issues, from SCTP abort to rx RANAP RESET.

    If it is only really (expècted to be) sent due to RANAP messages as current comment above it suggest, then it should contain the RANAP word.

To view, visit change 33173. To unsubscribe, or for help writing mail filters, visit settings.