Attention is currently required from: fixeria, neels.
Patch set 2:-Code-Review
View Change
1 comment:
Patchset:
Patch Set #2:
While this approach may work in practice, I find it a bit inelegant. […]
After reading Neel's comments I think he has a point there. IIUC the summary is that instead of blindly eg. 5 seconds upon every LU, we should instead trigger fetching if there's more SMS to send and then once done destroy it.
I guess that's well under 5 seconds or alike in usual case?
To view, visit change 36760. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 16:58:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: comment