Attention is currently required from: daniel, dexter, fixeria.

Patch set 8:Code-Review +1

View Change

2 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #8, Line 37: PQSQL

    PGSQL or PSQL are usual acronyms for postgres. But not PQSQL

  • Patch Set #8, Line 261: str(Path.home()) + "/.osmocom/pysim/card_data_pqsql.cfg"

    Not critical, but I guess the clean/pythonic way would be to use `os.path.join() to concatenate paths. Furthermore, you can use
    `os.path.expanduser("~/.osmocom/pysim/card_data_pgsql.cfg")` to avoid nany manual concatenation whatsoever.

    If that is needed at all? Why should the help print the absolute path instad the ~/... referring to the users home? Keeping the "~" would make he help output consistent across systems, and not expose user names (through directory names) if someone copy+pastes something into a bug report or mailing list / forum post.

To view, visit change 41508. To unsubscribe, or for help writing mail filters, visit settings.