Attention is currently required from: Hoernchen.

View Change

2 comments:

• File sysmoOCTSIM/hpl/core/hpl_init.c:

  • Patch Set #1, Line 57:

    // _osc32kctrl_init_sources();
    	// _oscctrl_init_sources();
    	// _mclk_init();
    // #if _GCLK_INIT_1ST
    // 	_gclk_init_generators_by_fref(_GCLK_INIT_1ST);
    // #endif
    // 	_oscctrl_init_referenced_generators();
    

    Because this serves as a reminder what must be done to run the fw without a bl + allows conveniently […]

    I'd recommend to put it in a #if 0 / #endif block and include a comment stating the purpose. or what about a self-explanatory

    ```
    #define BOOT_WITHOUT_BOOTLOADER 0
    #if BOOT_WITHOUT_BOOTLOADER != 0
    ...
    #endif
    ```
    or the like?

• File sysmoOCTSIM/main.c:

  • Patch Set #1, Line 579: if(delayed_usb_reset)

    the format issues happened during cleanup and merging of a dozen different branches with code in sep […]

    can we please avoid introducing more code that's not formatted correctly? I really don't want to have those kind of debates. 99.5% of all patches we review in gerrit are not raising obvious whitespace/formatting issues, AFAICT.

To view, visit change 39445. To unsubscribe, or for help writing mail filters, visit settings.