Attention is currently required from: arehbein, laforge, daniel.

View Change

2 comments:

• File tests/stream/stream_test.c:

  • Patch Set #10, Line 540: osmo_stream_cli_set_addr(osc, "127.0.0.11");

    I don't understand the second part of the sentence... […]

    What I meant is that in linux for the loopback interface the range 127.0.0.X of addresses don't need to explicitly be assigned to the network interface, they are added automagically when needed. Not critical, just sharing that this may pose problems on other systems.

  • Patch Set #10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start);

    What is the advantage of using `alarm()` instead, and how wouldn't I need to register some sort of ( […]

    The advantage is not mixing the code testing the API with the test-code itself. That makes the test easier to read, easier to extend, easier to debug.

To view, visit change 33197. To unsubscribe, or for help writing mail filters, visit settings.