Attention is currently required from: fixeria.

View Change

1 comment:

• File src/common/l1sap.c:

  • Patch Set #2, Line 2358:

    		/* This static function should never be called except for
    		 * V1 and EFR speech modes. */
    		
    

    I suggest to return here, like you do above: […]

    If we were to call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally like you suggest, the code at the top of `tch_ul_fr_hr_efr()` before the per-codec switch will execute for all channel modes, including those that aren't FR/HR/EFR. While no actual harm will result, it still feels philosophically wrong. Therefore, I prefer to keep the current arrangement.

To view, visit change 41048. To unsubscribe, or for help writing mail filters, visit settings.