Attention is currently required from: pespin.

View Change

4 comments:

• File src/osmo-bsc/abis_rsl.c:

  • Patch Set #4, Line 1013: msgb_put_u32(msg, msg_id);

    Just curious, did you check if Ericsson expects this ERIC_MOBILE_ID to actually be the TLLI? Or it's […]

    I have checked this back, when I get everything right, then it is just an identifier that is loosely connected to a specific MS.

    To be 100% sure that it is really just a number and not required to be the TLLI i did an experimet with osmo_swab32() in abis.rsl. It still works the same.

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #4, Line 557: } else {

    > else is not generally useful after a break or return […]

    Done

  • Patch Set #4, Line 558: if (pcu_rx_rr_paging_pch(bts, pag_grp, pch))

    > code indent should use tabs where possible […]

    Done

  • Patch Set #4, Line 561: return pcu_tx_pch_confirm(bts, pch->msg_id);

    why are you confirming it here? You should be confirming it when scheduling it / sending it to the B […]

    When pcu_rx_rr_paging_pch() returns, the message is sent out via RSL (in theory, in practice everything should happen in the next mainloop cycle). The BTS however, may have of course a paging queue which may introduce a delay, so it is not as accurate as in osmo-bts.

To view, visit change 34192. To unsubscribe, or for help writing mail filters, visit settings.