laforge submitted this change.

View Change


Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified
core: Check return value of osmo_fd_register()

Change-Id: I15bb456c42d5033c9cf4c0937df22fa02b6a6086
---
M src/core/tun.c
1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/core/tun.c b/src/core/tun.c
index 4c9dec1..33c62d5 100644
--- a/src/core/tun.c
+++ b/src/core/tun.c
@@ -399,10 +399,15 @@
if (rc < 0)
goto err_close_tun;

- osmo_fd_register(&tundev->wqueue.bfd);
+ rc = osmo_fd_register(&tundev->wqueue.bfd);
+ if (rc < 0)
+ goto err_unregister_netdev;
+
tundev->opened = true;
return 0;

+err_unregister_netdev:
+ osmo_netdev_unregister(tundev->netdev);
err_close_tun:
close(tundev->wqueue.bfd.fd);
tundev->wqueue.bfd.fd = -1;

To view, visit change 32649. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I15bb456c42d5033c9cf4c0937df22fa02b6a6086
Gerrit-Change-Number: 32649
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged