pespin has uploaded this change for review.

View Change

pcap-client: Move conns llist initialization to constructor

Change-Id: Ib67efa0579755a117c7680f490916e37165204cc
---
M src/osmo_client_core.c
M src/osmo_client_main.c
2 files changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/65/39165/1

diff --git a/src/osmo_client_core.c b/src/osmo_client_core.c
index 4bb4b4e..313fbeb 100644
--- a/src/osmo_client_core.c
+++ b/src/osmo_client_core.c
@@ -351,8 +351,11 @@
 	client = talloc_zero(tall_ctx, struct osmo_pcap_client);
 	if (!client)
 		return NULL;
+
 	client->fd.fd = -1;
 	client->snaplen = DEFAULT_SNAPLEN;
+	INIT_LLIST_HEAD(&pcap_client->conns);
+
 	return client;
 }
 
diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c
index 818a2f1..c523df3 100644
--- a/src/osmo_client_main.c
+++ b/src/osmo_client_main.c
@@ -262,7 +262,6 @@
 	}
 
 	/* initialize the queue */
-	INIT_LLIST_HEAD(&pcap_client->conns);
 	osmo_client_conn_init(&pcap_client->conn, pcap_client);
 	pcap_client->conn.name = "default";
 

To view, visit change 39165. To unsubscribe, or for help writing mail filters, visit settings.