Attention is currently required from: jolly, laforge.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 13: Change-Id: I9045437d52984b7abe00fbc815d7f83c62c0fb5a

    `Depends: libosmocore.git Ibd6a1d468a70126a8f67e944fcb916969cc3c36b`
    Also, I think you need to update `TODO-RELEASE` file?

• File src/common/scheduler.c:

  • Patch Set #1, Line 1153: /* look for

    in which situation would we want to enable/disable rach detection for multiple l1sched_chan at the s […]

    AFAIR, in this context it means both main (DCCH/TCH) and associated (SACCH) channels. The scheduler maintains separate states for these. They both have the same `chan_nr`, but different `link_id` in `trx_chan_desc[]`.

    I am not sure if it's valid to expect Access Bursts on SACCH too. I would expect the MS to transmit them on the main (DCCH/TCH) only. But the transceiver would most likely make no distinction and perform AB detection on both.

  • Patch Set #1, Line 1156: struct l1sched_ts *l1ts = lchan->ts->priv;

    This pointer can be obtained only once outside of the loop. The code above in `trx_sched_set_lchan()` does additionally check `l1ts` against `NULL` - we may want to do the same here too. Though I don't remember in which cases an `lchan` would have no associated `l1ts`, perhaps when it's not active?

To view, visit change 34886. To unsubscribe, or for help writing mail filters, visit settings.