Attention is currently required from: Timur Davydov, laforge, neels.

View Change

5 comments:

• File configure.ac:

  • Patch Set #16, Line 259: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes" && test "x$emscripten" != "xyes")

    This will still probably need fixing in a separate patch like the NETNS stuff you fixed

• File src/core/Makefile.am:

  • Patch Set #16, Line 87: if ENABLE_TUN

    This will probably need some sort of other fix? Why can't you add it when building for emscripten?

• File src/core/osmo_io_internal.h:

  • Patch Set #16, Line 5: #include "../config.h"

    This and the change below deserve a separate patch, feel free to submit previously in the branch to gerrit.

• File src/core/stats_tcp.c:

  • Patch Set #16, Line 198: #if !defined(__EMSCRIPTEN__)

    This should be fixed in a more generic way. Why can't you build this with emscripten? what's the exact error? we should check for that.

• File src/vty/logging_vty.c:

  • Patch Set #16, Line 937: #if !defined(__EMSCRIPTEN__)

    what about leaving this in and let it fail during runtime if user tries to use it?

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.