Attention is currently required from: laforge, pespin, fixeria.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #6, Line 1274: if (OSMO_UNLIKELY((resp_msg->len != GSM_HR_BYTES + 1) && rfc5993)) {

    Should this be: […]

    Yes, I want to know if the received format is not supported.

    The supported format is either rfc5993 or ts101318. I have swapped the bool value that defines if the format is expected or not at the beginning, this should be easier to read. I am also using the constants you suggested.

    (I think you mixed up the two formats, at least in the suggested formats you do. RFC5993 is the format with the added ToC byte at the beginning.)

  • Patch Set #6, Line 1279: } else if (OSMO_UNLIKELY((resp_msg->len != GSM_HR_BYTES) && ts101318)) {

    same here, !rfc5993

    Done

  • Patch Set #6, Line 1950: } else if (lchan->type == GSM_LCHAN_TCH_H && rtp_pl_len == GSM_HR_BYTES + 1

    I see you are using "GSM_HR_BYTES" and "GSM_HR_BYTES + 1" in several places. […]

    The GSM_HR_BYTES_RTP_ constants should be in libosmocore. We also have to deal with the two formats in osmo-mgw, so they may be of use there as well.

To view, visit change 31417. To unsubscribe, or for help writing mail filters, visit settings.