Attention is currently required from: pespin.

View Change

13 comments:

• File include/osmocom/sigtran/osmo_ss7.h:

  • Patch Set #1, Line 155: * QoS Class

    Better create a new private ss7_qos_class.h + ss7_qos_class. […]

    Done

  • Patch Set #1, Line 167: osmo_ss7_qos_class_find(struct osmo_ss7_instance *inst, uint8_t qos_class);

    This one can go in ss7_instance.h + ss7_instance. […]

    functions moved to ss7_qos_class.c/h

• File src/Makefile.am:

  • Patch Set #1, Line 92: ss7_qos_class_vty.c \

    good, you need to do the same with ss7_qos_class.c and .h.

    Done

• File src/ss7_asp_vty.c:

  • Patch Set #1, Line 414: "qos-class " IP_QOS_CLASS_RANGE_STR,

    SS7_QOS_CLASS_RANGE_STR

    Done

  • Patch Set #1, Line 423: asp->cfg.ip_dscp = 0;

    why do you keep asp->cfg.ip_dscp? IMHO it should be removed now that we have the qos-class stuff.

    You were mentioning in the ticket OS#6753:

    "Since we already released libosmo-sigtran with the "ip-dscp" command, it is fine to keep it as an alternative way to configure the DSCP per ASP."

  • Patch Set #1, Line 443: DEFUN_ATTR(asp_ip_dscps, asp_ip_dscp_cmd,

    This should be deprecated in some way imho.

    Done

• File src/ss7_instance.c:

  • Patch Set #1, Line 363: llist_for_each_entry(xua, &inst->xua_servers, list) {

    Cisco ITP doesn't have qos-class node for "listen" node, but I think it's actually a good idea to us […]

    Yes, it is essential, if we want DSCP for handshake packet.

  • Patch Set #1, Line 392: void osmo_ss7_qos_class_update(struct osmo_ss7_qos_class *qos)

    This can go into ss7_qos_class.c too. […]

    Done

• File src/ss7_qos_class_vty.c:

  • Patch Set #1, Line 112: if (qos->ip_dscp) {

    I think is "qos" exists it should always print the "qos class" node, even if empty.

    Done

  • Patch Set #1, Line 114: if (qos->ip_dscp)

    this is always true in this path?

    Fixed

• File src/ss7_vty.c:

  • Patch Set #1, Line 1409: /* then dump ASPs, as ASs reference them */

    I think you can simplify and drop all the connectors "first, then, now, finally" ;)

    Done

  • Patch Set #1, Line 1442: return ss7_vty_node_qos_class_go_parent(vty);

    Are you sure the func is needed? or simply apply it directly here like others?

    Done

  • Patch Set #1, Line 1548:

    remove this empty line.

    Done

To view, visit change 43667. To unsubscribe, or for help writing mail filters, visit settings.