Attention is currently required from: jolly.

Patch set 6:Code-Review +1

View Change

1 comment:

• File src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c:

  • Patch Set #6, Line 86: res->eim_acknowledgements = &msg_to_ipa->choice.provideEimPackageResultResponse.choice.eimAcknowledgements;

    I wonder if we should be more explcit in the case of an emptyResponse. We could have a bool empty_response in the result and set that to true in case ProvideEimPackageResultResponse_PR_emptyResponse is present. Then the caller has a more exact result.

    We also do not return the provideEimPackageResultError field yet. Maybe we should do that.

    (sure, the caller can always look into msg_to_ipa but that pointer servers more as an input for the free functions. The philosophy is to bring the interesting IEs directly to the front in the response structure.)

To view, visit change 43055. To unsubscribe, or for help writing mail filters, visit settings.