Attention is currently required from: Timur Davydov.

View Change

5 comments:

• Patchset:

  • Patch Set #1:

    You are again mixing different unrelated stuff in the same patch, which is confusing when reviewing the patch.
    Please split this into separate orthogonal topics.

• Commit Message:

  • Patch Set #1, Line 12: - Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use

    This should be a separate commit, since it's not related at all to the other ones.

• File configure.ac:

  • Patch Set #1, Line 242: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes")

    Why are you adding ENABLE_TUN? It's never set to "no".

• File include/osmocom/core/netns.h:

  • Patch Set #1, Line 5: #if (USE_NETNS)

    if netns is not supported, modify Makefile.am to avoid adding this file to the buildset.

• File src/core/Makefile.am:

  • Patch Set #1, Line 83: if ENABLE_TUN

    WHy this? AFAICT it can ever be false?

To view, visit change 41878. To unsubscribe, or for help writing mail filters, visit settings.