dexter submitted this change.

View Change

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved
l1sap: remove unused pointer variable

The pointer variable l1sap is only used to determine the size of the
related struct but for nothing else. We can use the struct name in
sizeof also directly and get rid of it.

Change-Id: I93abdce1dec60d53ddceb1fce6e9e7451ba6283a
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 8bcd417..22b5e8c 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1882,7 +1882,6 @@
{
struct gsm_lchan *lchan = rs->priv;
struct msgb *msg;
- struct osmo_phsap_prim *l1sap;

/* if we're in loopback mode, we don't accept frames from the
* RTP socket anymore */
@@ -1893,7 +1892,7 @@
if (!msg)
return;
memcpy(msgb_put(msg, rtp_pl_len), rtp_pl, rtp_pl_len);
- msgb_pull(msg, sizeof(*l1sap));
+ msgb_pull(msg, sizeof(struct osmo_phsap_prim));

/* Store RTP header Marker bit in control buffer */
rtpmsg_marker_bit(msg) = marker;

To view, visit change 30522. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I93abdce1dec60d53ddceb1fce6e9e7451ba6283a
Gerrit-Change-Number: 30522
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: merged