Attention is currently required from: jolly, laforge, lynxis.
Patch set 7:Code-Review +1
View Change
1 comment:
File src/slotmap.c:
Patch Set #7, Line 123: map_found = map;
why keep iterating here once found? is there any rationale to picking the last one instead of the first one?
To view, visit change 43743. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ibc9f771cda5d3ba94934cb04e00e60acd466e8bf
Gerrit-Change-Number: 43743
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis <lynxis@fe80.eu>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: lynxis <lynxis@fe80.eu>
Gerrit-Comment-Date: Fri, 13 Nov 2026 10:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes