Attention is currently required from: laforge, pespin.
4 comments:
Commit Message:
Patch Set #3, Line 17: This change ensures that newly received data is appended to the existing
This is still confusing to me, because you are still using the term "pending buffer" twice. […]
Done
File src/core/osmo_io.c:
Patch Set #3, Line 178: struct msgb *iofd_msgb_alloc2(struct osmo_io_fd *iofd, size_t size)
I agree with @pespin@sysmocom.de here. […]
Yes the pending buffer that is created with given size is always larger than the msgb_size configured by the user. It cannot be smaller, because it is created when a regular pending buffer (of msgb_size) is too small to append subsequent received data.
Patch Set #3, Line 335: * If the pending message is not large enough, create a larger message. */
> The application should only care about the length of data in the buffer not the size. […]
The larger buffer is only used for segentation process. The data that is sent to the user will have the length that the user requested as segment size. This less or equal the msgb_size that the user configured.
Patch Set #3, Line 344: memcpy(msgb_put(iofd->pending, msgb_length(msg)), msgb_data(msg), msgb_length(msg));
How? The fist memcopy is used, if the pending buffer must be enlarged. […]
Done
To view, visit change 40584. To unsubscribe, or for help writing mail filters, visit settings.