Attention is currently required from: osmith, neels, laforge, fixeria, msuraev.

Patch set 8:Code-Review -1

View Change

2 comments:

• File src/vty/logging_vty.c:

  • Patch Set #8, Line 815: tgt = log_target_find(LOG_TGT_TYPE_GSMTAP, hostname);

    Now if you do:
    """
    log gsmtap foobar 127.0.0.1
    log gsmtap foobar 127.0.0.2
    """
    The second one is a noop, which is probably not expected.

• File utils/osmo-stat-dummy/osmo-stat-dummy.cfg:

  • Patch Set #4, Line 1: log gsmtap 127.0.0.69 127.6.9.1

    Which one?

    I would really not add this here. The default of selecting source address based on routing makes a lot more sense than adding an ip addr which may not exist.

To view, visit change 31513. To unsubscribe, or for help writing mail filters, visit settings.