kirr has uploaded this change for review.

View Change

trx_toolkit/transceiver: Do not scan tx_queue twice on tx path

Noticed while moving forwarding out of tx_queue_lock in the previous patch.

Change-Id: I225c44c4cc327b6786efce96d1278c6ec68fbc25
---
M src/target/trx_toolkit/transceiver.py
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/34/39534/1

diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py
index 7297abf..2a638c5 100644
--- a/src/target/trx_toolkit/transceiver.py
+++ b/src/target/trx_toolkit/transceiver.py
@@ -310,6 +310,7 @@
 
 		drop = []
 		emit = []
+		wait = []
 
 		self._tx_queue_lock.acquire()
 
@@ -318,8 +319,10 @@
 				drop.append(msg)
 			elif msg.fn == fn:
 				emit.append(msg)
+			else:
+				wait.append(msg)
 
-		self._tx_queue = [msg for msg in self._tx_queue if msg.fn > fn]
+		self._tx_queue = wait
 		self._tx_queue_lock.release()
 
 		for msg in emit:

To view, visit change 39534. To unsubscribe, or for help writing mail filters, visit settings.