fixeria submitted this change.

View Change

Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve
osmo_dia2gsup: add and use parse_addr/1

Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e
---
M src/osmo_dia2gsup.erl
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl
index 7c4f2c1..b60d049 100644
--- a/src/osmo_dia2gsup.erl
+++ b/src/osmo_dia2gsup.erl
@@ -106,7 +106,7 @@
Port = get_env(diameter_port, 3868),
Proto = get_env(diameter_proto, sctp),
ConnectTimer = get_env(diameter_connect_timer, 30000),
- listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}),
+ listen(?SVC_NAME, {address, Proto, parse_addr(Ip), Port}, {timer, ConnectTimer}),
lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]),
{ok, State}.

@@ -156,3 +156,14 @@

tmod(tcp) -> diameter_tcp;
tmod(sctp) -> diameter_sctp.
+
+parse_addr(any) -> any;
+parse_addr(localhost) -> localhost;
+
+parse_addr(AddrStr) when is_list(AddrStr) ->
+ {ok, Addr} = inet:parse_address(AddrStr),
+ Addr;
+
+parse_addr(Addr) ->
+ true = inet:is_ip_address(Addr),
+ Addr.

To view, visit change 40124. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e
Gerrit-Change-Number: 40124
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>