Attention is currently required from: pespin.

View Change

1 comment:

• File src/osmo-bsc/handover_fsm.c:

  • Patch Set #3, Line 743: if (chosen_a5_n > 0) {

    What about checking if chosen_a5_n is in the intersection of bsc+msc. […]

    The Chosen Enc Alg is not mandating that we should choose it. It is not an error to use another cipher that is in the intersection of permitted algos.

    The effect would be that if one BSC supports only A5/2, then we would carry on this limitation across all future BSCs of that call being handed over. Worse, if the source BSC supports only A5/2, and the target supports A5/1 and A5/3, we would error instead of simply using A5/3.

    It makes more sense to use the best availale cipher in each BSC. This is what I did not understand when I wrote this code back in the days.

To view, visit change 27249. To unsubscribe, or for help writing mail filters, visit settings.