Attention is currently required from: daniel, laforge, pespin.

View Change

5 comments:

• File src/ss7_as_vty.c:

  • Patch Set #4, Line 269: "When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled.\n"

    "associated" […]

    Done

  • Patch Set #4, Line 547: const char *tcap_unroutable_str = get_value_string_or_null(osmo_ss7_as_tcap_unroutable_vals,

    This only makes sense in SS7_AS_TCAP_UNROUTABLE_ROUTE_FALLBACK case afaiu, so better move this looku […]

    No, it is also used by LOAD_SHARE_AS.

• File src/tcap_as_loadshare.c:

  • Patch Set #4, Line 469: struct osmo_mtp_transfer_param new_mtp = {};

    since you are copying orig_mtp just below, there's no need to zero-initialize the struct here.

    Done

  • Patch Set #4, Line 478: /*! When a TCAP MSU from an ongoing session (TCAP != Begin) could not routed either by the TCAP session tracking or

    could not be routed.

    Done

  • Patch Set #4, Line 504: /* No ASP selection because the SCCP msg will be routed else where */

    elsewhere

    Done

To view, visit change 43008. To unsubscribe, or for help writing mail filters, visit settings.