Attention is currently required from: daniel, fixeria, laforge, osmith.
View Change
1 comment:
File src/xua_asp_fsm.c:
Patch Set #1, Line 1119: for (unsigned i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) {
I am wondering if we can optimize this a bit by calculating a bitmask of used ASP IDs first? You cou […]
We could, but it's not really a problem right now, we use this same construct in all plces iterating ASPs for now.
Bear in mind ARRAY_SIZE() is 16 here, and this is only called upon IPA handshake time, so really not important.
To view, visit change 40003. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75
Gerrit-Change-Number: 40003
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Apr 2025 17:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>