Attention is currently required from: fixeria, laforge, pespin.

3 comments:

Patchset:
- Patch Set #2:
  I don't have a strong preference here... […]
  There is a better solution, I used to resolve this problem:
  The channels are activated quite quickly after each other. The BTS will take a while, to acknowledge the channel activations or reject them. The BSC will wait until all requested channels have been activated or rejected. Then the SI10 is generated. This way the SI10 is generated and sent to the BTSs only once.
  In case the channels are requested with a delay (congestions/errors on the A-Interface), the BSC will generate SI10 as soon as all (so fare) requested channels have been activated or rejected. Then, if more channels get requested by the MSC later, the BSC will update SI10, when all further channels have been activated or rejected.
File src/osmo-bsc/system_information.c:
- Patch Set #2, Line 1428:
```
unsigned int save_cur_bit;
	struct gsm_subscriber_connection *c;
```
  variables should always be declared with the smallest possible scope. […]
  Done
File src/osmo-bsc/system_information.c:
- Patch Set #4, Line 1456: llist_for_each_entry(c, &conn->vgcs_chan.call->vgcs_call.chan_list, vgcs_chan.list) {
  I always want to separate variables from code. […]
  Done

To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.