View Change

8 comments:

• File include/osmocom/abis/websdr.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 60: #endif /* OSMO_ABIS_WEBSDR_H */

    adding a line without newline at end of file

• File src/input/websdr.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 88: if (!msg) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 145: switch(line->ops->cfg.ipa.role) {

    space required before the open parenthesis '('

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 405: struct e1inp_line* line = g_line_cb;

    "foo* bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 447: } else {

    else is not generally useful after a break or return

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 502: if (ret == 0)

    suspect code indent for conditional statements (16, 23)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 503: goto discard_msg;

    Statements should start on a tabstop

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 601: int ws_ipa_push_raw_data(unsigned ts_nr, const char* data, unsigned sz)

    "foo* bar" should be "foo *bar"

To view, visit change 42652. To unsubscribe, or for help writing mail filters, visit settings.