Attention is currently required from: laforge, pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #5:

    I have revisited the patch. Now everything should be clear.

• File src/libmsc/sgs_iface.c:

  • Patch Set #2, Line 178:

    I'm also personally fine with accepting a non-3GPP FQDN there. […]

    I have now looked at everything again and now everything makes sense to me. I have updated the comments so that it is easier to understand. We basically just tolerate two different domain name formats with the same domain name in it.

  • Patch Set #2, Line 204: OSMO_ASSERT(osmo_parse_mme_domain(&gummei, mme_fqdn) == 0);

    Ah, no. Looks like a made a thinking mistake here. Let's forget about this.

    This path was indeed completely wrong. I just had a knot in my brain...

To view, visit change 43237. To unsubscribe, or for help writing mail filters, visit settings.