Attention is currently required from: pespin. 
View Change
2 comments:
- File src/socket.c: - Patch Set #1, Line 1746: - 	size_t l;
 - use len if possible, my eyes hurt seeing number ones everywhere due to l and 1 looking similar :P - lol, right =) 
- Patch Set #1, Line 1747: - 	switch (os->u.sin.sin_family) {
 - os->u.sa. […] - i'm still confused with all the different sockaddrs, thx 
 
To view, visit change 27050. To unsubscribe, or for help writing mail filters, visit settings.
 Gerrit-Project: libosmocore 
 Gerrit-Branch: master 
 Gerrit-Change-Id: Ie9e33bfac525c59c30714663d2bfcc62ec9eeb81 
 Gerrit-Change-Number: 27050 
 Gerrit-PatchSet: 1 
 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> 
 Gerrit-Reviewer: Jenkins Builder 
 Gerrit-Reviewer: dexter <pmaier@sysmocom.de> 
 Gerrit-Reviewer: laforge <laforge@osmocom.org> 
 Gerrit-CC: pespin <pespin@sysmocom.de> 
 Gerrit-Attention: pespin <pespin@sysmocom.de> 
 Gerrit-Comment-Date: Mon, 07 Feb 2022 21:14:04 +0000 
 Gerrit-HasComments: Yes 
 Gerrit-Has-Labels: No 
 Comment-In-Reply-To: pespin <pespin@sysmocom.de> 
 Gerrit-MessageType: comment