Attention is currently required from: pespin.
Patch set 1:Code-Review +1
2 comments:
Patchset:
this case of sctp_notification is confusing; if it was clear, the ret from sctp_recvmsg() would return the size of the union sctp_notification, and we would always msgb_put() if rc > 0, and not use sizeof(). Do you think that could work / makes sense / have you tried that?
'man sctp_recvmsg' is a very short joke; would be nice to have the relation of ret, flags and sizeof explained by in-code comments, at least what we assume to be true.
if there's anything you can improve, that would be welcome.
File src/stream.c:
Patch Set #1, Line 1563: msgb_put(msg, ret);
This is the generic and regular place where user data content is updated in the msgb, so it's fine h […]
i understand now that this is needed here for the recv() case.
To view, visit change 29540. To unsubscribe, or for help writing mail filters, visit settings.