Attention is currently required from: fixeria, dexter.

View Change

1 comment:

• File pySim-shell.py:

  • Patch Set #12, Line 162: # pylint: disable=E1121

    I have tested this also with too-many-function-args but it seems not to be recognized by pylint. […]

    We currently use a rather old pylint version (the one in debian buster), so apparently it doesn't disable the check for the whole block as it says in the documentation.

    Adding it at the end of each line, and adding a \ for multiline statements makes it work with the current version in the meantime.

    ```
                self.add_settable(cmd2.Settable('numeric_path', bool, 'Print File IDs instead of names', self, \
                                                onchange_cb=self._onchange_numeric_path))  # pylint: disable=too-many-function-args
                self.add_settable(cmd2.Settable('conserve_write', bool, 'Read and compare before write', self, \
                                                onchange_cb=self._onchange_conserve_write))  # pylint: disable=too-many-function-args
                self.add_settable(cmd2.Settable('json_pretty_print', bool, 'Pretty-Print JSON output', self))  # pylint: disable=too-many-function-args
                self.add_settable(cmd2.Settable('apdu_trace', bool, 'Trace and display APDUs exchanged with card', self, \
                                                onchange_cb=self._onchange_apdu_trace))  # pylint: disable=too-many-function-args
    ```

    as diff:

    ```
    diff --git a/pySim-shell.py b/pySim-shell.py
    index 1e390d2..f265f5d 100755
    --- a/pySim-shell.py
    +++ b/pySim-shell.py
    @@ -159,14 +159,13 @@ class PysimApp(cmd2.Cmd):
                 self.add_settable(cmd2.Settable('apdu_trace', bool, 'Trace and display APDUs exchanged with card',
                                                 onchange_cb=self._onchange_apdu_trace))
             else:
    -            # pylint: disable=E1121
    -            self.add_settable(cmd2.Settable('numeric_path', bool, 'Print File IDs instead of names', self,
    -                                            onchange_cb=self._onchange_numeric_path))
    -            self.add_settable(cmd2.Settable('conserve_write', bool, 'Read and compare before write', self,
    -                                            onchange_cb=self._onchange_conserve_write))
    -            self.add_settable(cmd2.Settable('json_pretty_print', bool, 'Pretty-Print JSON output', self))
    -            self.add_settable(cmd2.Settable('apdu_trace', bool, 'Trace and display APDUs exchanged with card', self,
    -                                            onchange_cb=self._onchange_apdu_trace))
    +            self.add_settable(cmd2.Settable('numeric_path', bool, 'Print File IDs instead of names', self, \
    +                                            onchange_cb=self._onchange_numeric_path))  # pylint: disable=too-many-function-args
    +            self.add_settable(cmd2.Settable('conserve_write', bool, 'Read and compare before write', self, \
    +                                            onchange_cb=self._onchange_conserve_write))  # pylint: disable=too-many-function-args
    +            self.add_settable(cmd2.Settable('json_pretty_print', bool, 'Pretty-Print JSON output', self))  # pylint: disable=too-many-function-args
    +            self.add_settable(cmd2.Settable('apdu_trace', bool, 'Trace and display APDUs exchanged with card', self, \
    +                                            onchange_cb=self._onchange_apdu_trace))  # pylint: disable=too-many-function-args
             self.equip(card, rs)
     
         def equip(self, card, rs):
    ```

To view, visit change 32532. To unsubscribe, or for help writing mail filters, visit settings.