pespin submitted this change.

View Change


Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified
asterisk: IMS: Validate Expires=600000 in REGISTER as per specs

Change-Id: Ibf2e3ff36d0c7cc84d25328ffdf87a6cedc8a37b
---
M asterisk/IMS_ConnectionHandler.ttcn
1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn
index c06df15..7819e62 100644
--- a/asterisk/IMS_ConnectionHandler.ttcn
+++ b/asterisk/IMS_ConnectionHandler.ttcn
@@ -34,6 +34,7 @@
charstring mp_ipsec_setup_script_path := "./IMS_ipsec_setup.sh";
}

+const integer c_def_expires := 600000; /* 3GPP TS 24.229 5.1.1.2.1 e) */
const char c_sip_server_name := "osmo-ttcn3-hacks/0.23";


@@ -476,6 +477,7 @@
tr_From(),
tr_To(),
tr_Via_from(?),
+ expires := tr_Expires(int2str(c_def_expires)),
require := tr_Require(superset("sec-agree")),
security_client := tr_Security_client(superset(tr_Security_mechanism("ipsec-3gpp",
superset(tr_Param("alg","hmac-sha-1-96"))))),
@@ -519,8 +521,6 @@
*/
f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := false);

- /* TODO: Validate "Expires" is 600000 */
-
/* Tx 100 Tyring */
tx_resp := ts_SIP_Response_Trying(sip_call_id,
from_addr,

To view, visit change 37121. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibf2e3ff36d0c7cc84d25328ffdf87a6cedc8a37b
Gerrit-Change-Number: 37121
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged