Attention is currently required from: laforge, pespin, keith, dexter.
1 comment:
File src/ericsson-rbs/er_ccu_descr.h:
I am also not so happy with this. I was searching for a define constant, but I couldn't fine one. […]
I wouldn't bother adding this to libosmocore. It's a well-known constant for everyone working with GSM, which is not that hard to remember (compared to number of frames in a multiframe, for instance). I am fine with writing `foo[8]` in `*.h` files and then using `ARRAY_SIZE(foo)` in `*.c` files.
Maybe clarify the field name a but? How about `ts_ccu_descr` or `per_ts_ccu_descr`?
To view, visit change 32423. To unsubscribe, or for help writing mail filters, visit settings.