Attention is currently required from: neels, fixeria.

View Change

2 comments:

• File examples/sccp_test_vty.c:

  • Patch Set #8, Line 44: int conn_id = atoi(argv[0]), ret;

    I agree with Neels that doing "int a = ..., rc;" hides definition of rc. […]

    Done

• File src/sccp_scoc.c:

  • Patch Set #12, Line 459: osmo_sccp_conn_id_exists

    So this function basically converts the result of conn_find_by_id() to boolean. […]

    I'm sorry but I've completely lost track of your though in here. We need boolean value but instead of writing function which gives it we should expose another function which doesn't because new symbol?

To view, visit change 29087. To unsubscribe, or for help writing mail filters, visit settings.