Attention is currently required from: fixeria, laforge.
Patch set 7:Code-Review +1
1 comment:
File libosmo-trx/src/trx_ep.c:
Patch Set #6, Line 581: return !llist_empty(&ep->closing_flushes);
P.S. I am really tired of re-working this patch over and over, and I
really wish flushing was implemented in libosmocore. Having to implement
this outside of libosmocore feels like a kludge.
I think I already clearly mentioned what I thought was needed since the first version of the patch, so it's not like I'm asking different things everytime.
Having to implement this outside of libosmocore is imho what's needed here, and implementing it inside libosmocore would be a kludge. This protocol has the specific requirement that one wants to make sure all data is sent before closing the socket, and you want all the other data domain to actually be aware of that and be able to track the state of that at the upper level possible, by making it public that closing is as asynchronous action which may take some time.
If the user wants to free everything instantanteously, it can still do so at the expense of not being sure the TRX was stopped.
Hiding this fact under several layers is only going to create problems in upper layers.
If you disagree fine and do as you wish, but I think it's my duty as a reviewer to point it out specially since I already implemented something relatively similar in osmo-pcap.
To view, visit change 43112. To unsubscribe, or for help writing mail filters, visit settings.