Attention is currently required from: pespin.

Patch set 2:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #2:

    logic looks fine, just some cosmetics

• File src/core/socket.c:

  • Patch Set #2, Line 922: IPv4 or IPv6

    IPv4-only or IPv6-only

  • Patch Set #2, Line 933: * Both are checked here through "or" here to account for "bind flag set,

    what do you mean with 'checked through "or" here', did you mean to write it like this?
    ```
    if (loc_has_v6addr || rem_has_v6addr)
    	family = AF_INET6;
    else
    	family = AF_INET;
    ```

  • Patch Set #2, Line 945: (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) {

    the if condition looks right, but is IMHO a bit hard to read, maybe move it / or the whole block here to a separate function?

To view, visit change 35232. To unsubscribe, or for help writing mail filters, visit settings.