Attention is currently required from: jolly.
8 comments:
File src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h:
Patch Set #5, Line 89: #define GSM48_RR_GST_OFF 0
can we have this as an enum?
Patch Set #5, Line 220: /* group call */
what about putting all this inside "gc" substruct?
Patch Set #5, Line 222: int group_state; /* extension to RR state for group transmit/receive modes */
can we have this as an enum?
Patch Set #5, Line 230: int uplink_tries; /* Counts number of tries to access the uplink. */
if it's a counter, do we need negative values (int)?
File src/host/layer23/src/mobile/gsm48_rr.c:
Patch Set #5, Line 73: * GSM48_MM_EVENT_UPLINK_BUSY: Notify MM layer about uplink becoming busy.
I think you added these a few commits before. They should probably be in this commit instead since this is where you are using them.
Patch Set #5, Line 134: static int gsm48_rr_render_ma(struct osmocom_ms *ms, struct gsm48_rr_cd *cd, uint16_t *ma, uint8_t *ma_len);
I bet some of this pointers can be const.
Patch Set #5, Line 414: if (rr->state == state && state != GSM48_RR_ST_IDLE) {
are you sure this is correct' this should be == iiuc, not !=.
we should start thinking about splitting this file into smaller pieces ;)
To view, visit change 34491. To unsubscribe, or for help writing mail filters, visit settings.