Attention is currently required from: fixeria.
View Change
1 comment:
File src/sccp2sua.c:
Patch Set #1, Line 74: if (in_num_bytes * 2 >= out_digits_size)
shouldn't you account for one extra byte in this check in the case it's even number of bytes? because then you need one extra digit anyway.
To view, visit change 43163. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8
Gerrit-Change-Number: 43163
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Aug 2026 14:13:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No